routers/plants/get_water_overview only talks inches #2

New issue

Closed

opened 2026-10-07 16:57:41 +11:00 by greg · 2 comments

greg commented

2026-10-07 16:57:41 +11:00

Owner

Stored data now can also be in metric units. get_water_overview needs to read (and use or convert) the units for each reading type.

greg added the

bug

label

2026-10-07 16:57:41 +11:00

greg self-assigned this

2026-10-07 16:57:42 +11:00

greg commented

2026-10-07 17:00:24 +11:00

Author

Owner

Line 1112:

rain_by_day.append({"date": day_str, "rain_inches": round(daily_rain, 2)})

Can maybe be replaced by something like this:

rain_by_day.append({"date": day_str, "rain": round(daily_rain, 2),"rain_units":rain_units})

And of course frontend/Plants.jsx will need to be updated to match

Line 1112: ``` rain_by_day.append({"date": day_str, "rain_inches": round(daily_rain, 2)}) ``` Can maybe be replaced by something like this: ``` rain_by_day.append({"date": day_str, "rain": round(daily_rain, 2),"rain_units":rain_units}) ``` And of course frontend/Plants.jsx will need to be updated to match

greg commented

2026-10-09 15:53:32 +11:00

Author

Owner

Closed with pull request 038e573452

Closed with pull request 038e573452417ecb1bed13d58dbe73cb35684556

greg closed this issue

2026-10-09 15:53:32 +11:00